-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for UUID v7 in RequestId
#116
Merged
LukeMathWalker
merged 7 commits into
LukeMathWalker:main
from
NishantJoshi00:feat/request_id_w_uuid_v7
Oct 20, 2023
Merged
add support for UUID v7 in RequestId
#116
LukeMathWalker
merged 7 commits into
LukeMathWalker:main
from
NishantJoshi00:feat/request_id_w_uuid_v7
Oct 20, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feature flag `uuid_v7` is introduced which inturn enables `v7` feature flag in the `uuid` dependency Support documentation is added in `README.md`, `src/lib.rs` and `src/request_id.rs` This feature only works if this crate or any crate dependent on this crate has enabled the compile time configuration flag provided to the rust compiler. `RUSTFLAGS="--cfg uuid_unstable"`.
Hey @LukeMathWalker, I have fixed the formatting and the Github action test created for |
Thank you! |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked Issue: #115
Description:
feature flag
uuid_v7
is introduced which inturn enablesv7
feature flag in theuuid
dependency Support documentation is added inREADME.md
,src/lib.rs
andsrc/request_id.rs
This feature only works if this crate or any crate dependent on this crate has enabled the compile time configuration flag provided to the rust compiler.
RUSTFLAGS="--cfg uuid_unstable"
.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.